php生成rss文件求改善

2013-11-29

php生成rss文件求改进我写了一个php利用DOMDocument 组件生成rss文件的代码，但是感觉太过于臃肿，想封装成

php生成rss文件求改进
我写了一个php利用DOMDocument 组件生成rss文件的代码，但是感觉太过于臃肿，想封装成一个类但是一直没成功，特来请教
生成后rss大体是这样的
<rss version="2.0">
<channel>
<item id="1">

<user><user_id>1</user_id><user_name/><user_pass>123</user_pass><real_name>木头</real_name></user>
<title>1</title>
<link>http://www.xxx.com</link>
<description>id:1,user_name:,pass:123,real_name:木头</description>
</item>
<item id="2">

<user><user_id>2</user_id><user_name/><user_pass>456</user_pass><real_name>小木头</real_name></user>
<title>2</title>
<link>http://www.xxx.com</link>
<description>id:2,user_name:,pass:456,real_name:小木头</description>
</item>

当然代码太过于冗余

$doc = new DOMDocument('1.0','utf-8');
$doc->formatOutput = true;

//创建标签
//创建rss标签
$rss = $doc->createElement('rss');
//创建channel下面的标签
$channel         = $doc->createElement('channel');
$ctitle         = $doc->createElement('title');
$clink             = $doc->createElement('link');
$cdescription     = $doc->createElement('description');

foreach ($arr as $key => $val) {
    //创建item标签
    $item             = $doc->createElement('item');
    //创建item下的子标签标签
    $user             = $doc->createElement('user');
    $ititle         = $doc->createElement('title');
    $ilink             = $doc->createElement('link');
    $idescription     = $doc->createElement('description');
    //创建user标签
    $user_id         = $doc->createElement('user_id');
    $user_name         = $doc->createElement('user_name');
    $user_pass         = $doc->createElement('user_pass');
    $real_name         = $doc->createElement('real_name');
    /*这里是需要数据库循环调用的地方*/
    //创建内容
    //创建item下面的标签的内容
    $c_ititle = $doc->createTextNode($val['user_id']);
    $c_ilink = $doc->createTextNode('http://www.xxx.com');
    $c_idescription = $doc->createTextNode('id:'.$val['user_id'].',user_name:'.$val['user_name'].',pass:'.$val['pass'].',real_name:'.$val['real_name']);
    //创建user下面的标签的内容
    $c_user_id        = $doc->createTextNode($val['user_id']);
    $c_user_name     = $doc->createTextNode($val['user_name']);
    $c_user_pass     = $doc->createTextNode($val['pass']);
    $c_real_name     = $doc->createTextNode($val['real_name']);
    //创建item属性值
    $a_id = $doc->createTextNode($val['user_id']);

    //创建属性
    $attributes = $doc->createAttribute('id');
    /*这里是需要数据库循环调用的地方*/
    //item一级标签的元素内容继承
    $ititle->appendChild($c_ititle);
    $ilink->appendChild($c_ilink);
    $idescription->appendChild($c_idescription);
    //user一级标签的元素内容继承
    $user_id->appendChild($c_user_id);
    $user_name->appendChild($c_user_name);
    $user_pass->appendChild($c_user_pass);
    $real_name->appendChild($c_real_name);
    /*这里是需要数据库循环调用的地方*/
    //继承
    $channel->appendChild($item);
    //item一级标签的标签继承
    $item->appendChild($user);
    $item->appendChild($ititle);
    $item->appendChild($ilink);
    $item->appendChild($idescription);
    //id=1
    $attributes->appendChild($a_id);
    //<item id="1">
    $item->appendChild($attributes);

    //item一级标签的标签继承
    $user->appendChild($user_id);
    $user->appendChild($user_name);
    $user->appendChild($user_pass);
    $user->appendChild($real_name);
}

//创建内容
//创建channel下面的标签的内容
$c_ctitle = $doc->createTextNode('测试rss');
$c_clink = $doc->createTextNode('http://www.xxx.com');
$c_cdescription = $doc->createTextNode('这是一个测试rss');
//创建rss版本属性值
$rss_attribute_c = $doc->createTextNode('2.0');

//创建rss版本属性
$rss_attribute = $doc->createAttribute('version');

//继承
//channel一级标签的元素内容继承
$ctitle->appendChild($c_ctitle);
$clink->appendChild($c_clink);
$cdescription->appendChild($c_cdescription);
//version="2.0"
$rss_attribute->appendChild($rss_attribute_c);

//channel一级标签的标签继承
$channel->appendChild($ctitle);
$channel->appendChild($clink);
$channel->appendChild($cdescription);

//创建根节点
$rss->appendChild($channel);
$rss->appendChild($rss_attribute);
$doc->appendChild($rss);

//保存xml文件
$doc->save('hello.xml');

function connect_sql(){
    $con = mysql_connect('localhost','root','123456') or die('mysql error :'.mysql_error());
    mysql_select_db('test');
    mysql_query('set names utf8');
}
function getall(){
    $sql = "SELECT * FROM test";
    $query = mysql_query($sql);
    $content = array();
    while($row = mysql_fetch_array($query)){
        $content[] = $row;
    }
    return $content;
}

请教各位大牛，怎样改装成一个class，我试了，一直不行
[解决办法]
为什么要用 dom 呢？
直接字符串拼装不就可以的吗？如

$ar = array(
  array(
    'id' => 1,
    'user' => array('user_id' => 1, 'user_name' => '', 'user_pass' => 123, 'real_name' => 'aa'), 
    'title' => 1,
    'link' => 'http://www.xxx.com',
    'description' => 'id:1,user_name:,pass:123,real_name:aa',
  ),
  array(
    'id' => 2,
    'user' => array('user_id' => 2, 'user_name' => '', 'user_pass' => 456, 'real_name' => 'bb'), 
    'title' => 2,
    'link' => 'http://www.xxx.com',
    'description' => 'id:1,user_name:,pass:456,real_name:bb',
  ),
);

<rss version="2.0">
<item id="1">
<id>1</id>
<user user_id="1" user_name="" user_pass="123" real_name="aa">
<title>1</title>
<link>http://www.xxx.com</link>
<description>id:1,user_name:,pass:123,real_name:aa</description>
</item>
<item id="2">
<id>2</id>
<user user_id="2" user_name="" user_pass="456" real_name="bb">
<title>2</title>
<link>http://www.xxx.com</link>
<description>id:1,user_name:,pass:456,real_name:bb</description>
</item>

热点排行

PHP

php生成rss文件求改善